Looks good but I'm confused about the MAINBOARD_VERSION
drop.
3 comments:
Patch Set #2, Line 15: - remove redundant MAINBOARD_VERSION option
How is it redundant? I didn't find another place
where it is set.
Patch Set #2, Line 16: - specify microcode length separately for SKL and KBL devices
I'm just wondering. This is only needed for FSP_CAR, right?
It's neither the default nor would I expect Purism to use it.
So you could probably save yourself some time, maintaining it.
File src/mainboard/purism/librem_skl/Kconfig:
Patch Set #2, Line 36: default "Librem 13 v2/v3" if BOARD_PURISM_LIBREM13_V2
NB. AIUI, this also alters the SMBIOS_PRODUCT_NAME
which is sometimes used in OS's to handle quirks.
To view, visit change 32515. To unsubscribe, or for help writing mail filters, visit settings.