Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82598?usp=email )
Change subject: device: drop unnecessary CHECK_REV_IN_OPROM_NAME option ......................................................................
Patch Set 3:
(5 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82598/comment/f11b630b_c0731baf?usp... : PS2, Line 11: which VGA BIOS file to run
worth stating it was for PCO only
added that info a bit earlier in the sentence
https://review.coreboot.org/c/coreboot/+/82598/comment/9838d59a_bace3af8?usp... : PS2, Line 12: introduces
introduced
Done
https://review.coreboot.org/c/coreboot/+/82598/comment/38c8cf6b_3cf3be09?usp... : PS2, Line 12: check
check*s*
Done
https://review.coreboot.org/c/coreboot/+/82598/comment/8ce7f96f_cfd05fce?usp... : PS2, Line 13: Later it turned out that there might be a case where even that isn't : sufficient,
there was one (or two?) case(s) where the same VID/DID/revision needed different VBIOS files; no ide […]
can i mark that one as resolved or do you have a better suggestion for this one?
https://review.coreboot.org/c/coreboot/+/82598/comment/8f44971c_f5cb94b9?usp... : PS2, Line 18: SaeaBIOS
SeaBIOS
Done