Attention is currently required from: Nico Huber, Paul Menzel, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42434 )
Change subject: cpu/x86/lapic: Only deliver ExtINT to BSP
......................................................................
Patch Set 11: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/42434/comment/8c5200dd_091892af
PS4, Line 9: aac79e0b8f4777f8a912ccdfc483755b7a4da52c changed the LAPIC delivery mode
This would need to be updated, I guess? CB:42219 was reverted
Done
https://review.coreboot.org/c/coreboot/+/42434/comment/3c6c2d59_7bce9aa2
PS4, Line 9: aac79e0b8f4777f8a912ccdfc483755b7a4da52c
Please use *commit aac79e0b (x86/lapic: Set EXTINT on BSP only)* in the future. […]
No longer applies
Commit Message:
https://review.coreboot.org/c/coreboot/+/42434/comment/bedb00cc_a2b3e6bf
PS5, Line 11: configuration than coreboot does with this patch applied.
Is this still up-to-date? I don't see how the current version could […]
Anything else to do? The commit message was updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78490d2cbe3d9f52e10ef2471508263fd6c146ba
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 13 Oct 2021 10:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment