Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40334 )
Change subject: configs/builder/config.ocp.sonorapass: Config for SonoraPass PO. src/mainboard/ocp/sonorapass/*.*: Preliminary platform porting for SonoraPass PO. ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@7 PS2, Line 7: configs/builder/config.ocp.sonorapass: Config for SonoraPass PO. : src/mainboard/ocp/sonorapass/*.*: Preliminary platform porting for SonoraPass PO. You should split it into 2 different patches for example Cedar Island board: CB:39783 and CB:39714
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@10 PS2, Line 10: It can boot SonoraPass EVT board w/ ES1 CPX-SP and ES PCH. Due to IRQs issue, it has yet to boot into Linuxboot/u-root payload. from https://www.coreboot.org/Git:
1. The first line of the commit message has a short (less than 65 characters, absolute maximum is 75) summary 2. The second line is empty (no whitespace at all) 3. The third and any number of following lines contain a longer description of the commit as is neccessary, including relevant background information and quite possibly rationale for why the issue was solved in this particular way. These lines should never be longer than 75 characters. 4. The next line is empty (no whitespace at all) 5. A Change-Id: line to let gerrit track this logical change 6. A Signed-off-by: line according to the development guidelines