Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/intel/skylake: Update GFX devtree options
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32044/8/src/soc/intel/skylake/romstage/romst...
File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/8/src/soc/intel/skylake/romstage/romst...
PS8, Line 258: if (config->PrimaryDisplay == Display_iGFX)
: m_cfg->PrimaryDisplay = Display_Auto;
: else
Is this really necessary? If I understand your findings correctly, […]
I think it is better not to use iGPU as a primary graphic device when it is turned off.
And if this happened, then the universal solution to this problem would be to use the “Auto” mode.
For example, in the future, I can add this check here:
If PEG is enabled, then m_cfg->PrimaryDisplay = Primary_PEG,
otherwise, m_cfg-> PrimaryDisplay = PCIe_PCH.
Or something like that...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Wed, 10 Apr 2019 13:02:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment