Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 )
Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File src/soc/intel/meteorlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/71644/comment/635382a0_9c70ed4f PS1, Line 172: // { SA_DEVFN_CPU_PCIE1_0, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_IGD, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_DPTF, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_IPU, ACPI_DEVICE_SLEEP_D3 }, : // { SA_DEVFN_CPU_PCIE6_0, ACPI_DEVICE_SLEEP_D3 }, : // { SA_DEVFN_CPU_PCIE6_2, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT0, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT1, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT2, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT3, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_GNA, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TCSS_XHCI, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TCSS_XDCI, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_TCSS_DMA0, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_TCSS_DMA1, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_VMD, ACPI_DEVICE_SLEEP_D3 }, : // { PCH_DEVFN_I2C6, ACPI_DEVICE_SLEEP_D3 }, : // { PCH_DEVFN_I2C7, ACPI_DEVICE_SLEEP_D3 }, Tarun, Regarding the commented out entries - I wasn't sure where you got these from in the original CL (https://review.coreboot.org/c/coreboot/+/63969) I couldn't find them on the 595644 doc mentioned in that CL. Can you please help with clarifying that? Thanks!