Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38657 )
Change subject: arch/x86/include/arch: Add ROM_TASK_STATE_SEG
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r...
File src/arch/x86/include/arch/rom_segs.h:
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r...
PS1, Line 20: ROM_TASK_STATE_SEG
That segment doesn't exist in romstage gdt, see src/arch/x86/gdt_init.S
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddb1f45444d03465a66a4ebb9fde5f206dc5b300
Gerrit-Change-Number: 38657
Gerrit-PatchSet: 1
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 Jan 2020 04:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment