Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c
File util/inteltool/usb.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@249
PS6, Line 249: *(usbbase+usb_registers[i].addr)
*((uint32_t*) (usbbase + usb_registers[i]. […]
Sorry for copy-paste
*((uint32_t*) (usbbase + usb_registers[i].addr))
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@255
PS6, Line 255: *(usbbase+usb_registers[i].addr)
*((uint16_t*) (usbbase + usb_registers[i]. […]
Sorry for copy-paste
*((uint16_t*) (usbbase + usb_registers[i].addr))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 11:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment