Hello Kyösti Mälkki, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36312
to look at the new patch set (#2).
Change subject: [TESTME]mb/asus/{p5gc-mx,p5qpl-am}: Use system_reset instead of full_reset ......................................................................
[TESTME]mb/asus/{p5gc-mx,p5qpl-am}: Use system_reset instead of full_reset
The GMCH needs to sample BSEL again after the SuperIO GPIO to configure BSEL have been set. This happens when RSTIN# is asserted, which in turn happens when PCIRST# is asserted by the southbridge.
This needs to be tested on hardware.
Change-Id: I246ac15d0d12ffc18686c7d22a9e6c2b43dce535 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/asus/p5qpl-am/romstage.c 2 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/36312/2