[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/denverton_ns: Allow using FSP repo

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30931 )

Change subject: soc/intel/denverton_ns: Allow using FSP repo
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/#/c/30931/3/src/soc/intel/denverton_ns/Kconfig 
File src/soc/intel/denverton_ns/Kconfig:

https://review.coreboot.org/#/c/30931/3/src/soc/intel/denverton_ns/Kconfig@8... 
PS3, Line 82: 	string "Location of FSP headers"
I don't understand it. Why does it need a prompt now? and didn't need
one before? How does it work when you don't use the repo?

This triggers a `-I` in a Makefile in `drivers/intel/fsp2_0/`. Where
is the existing `-I` that was used until now? Doesn't it have to be
adapted? Otherwise, we'd have two conflicting include paths.

https://review.coreboot.org/#/c/30931/3/src/soc/intel/denverton_ns/Kconfig@8... 
PS3, Line 88: 	default "3rdparty/fsp/DenvertonNSFspBinPkg/FspBin/DenvertonNSFsp.fd"
> I removed the prompt but not the declarations, because it's done like this on all other FSP platform […]

I really don't care about the existing weirdness. If you don't want to
make the code base worse, please try to understand what you are doing
and don't just copy-paste.