[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Init SPM driver

[DAWEI CHIEN (Code Review)]

DAWEI CHIEN has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )

Change subject: mediatek/mt8183: Init SPM driver
......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/sp... 
File src/soc/mediatek/mt8183/spm.c:

https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/sp... 
PS14, Line 331: if CONFIG(MT8183_DRAM_EMCP)
              : 	index = DYNA_LOAD_PCM_SUSPEND_LP4_3733;
              : #else
              : 	index = DYNA_LOAD_PCM_SUSPEND_LP4_3200;
              : #endif
> If you want to use CONFIG(), that must be 'if', not '#if'. […]

Hi Hung-Te,
Actually, it is what my latest patch, please refer to
https://review.coreboot.org/c/coreboot/+/34545/15/src/soc/mediatek/mt8183/sp...
but it build fail, maybe I lose anything?

if (CONFIG(MT8183_DRAM_EMCP))
    
    	index = DYNA_LOAD_PCM_SUSPEND_LP4_3733;
    
    else
    
    	index = DYNA_LOAD_PCM_SUSPEND_LP4_3200;