Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42141 )
Change subject: ec/google/wilco: Fix comment about enclosure type
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/42141/comment/a7c1e20c_3111d60f
PS1, Line 7: Fix
The comment was not wrong per se, as long as selecting SYSTEM_TYPE_CONVERTIBLE resulted in the SMBIO […]
Ack
File src/ec/google/wilco/acpi/vbtn.asl:
https://review.coreboot.org/c/coreboot/+/42141/comment/9d94aef6_b0741127
PS1, Line 8: * have SMBIOS_ENCLOSURE_CONVERTIBLE for the SMBIOS enclosure type to
It's not a decision, a proposal. Let's see what comments appear in CB:42142.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib658af7b80586428b22f08a738964637e1fbd17a
Gerrit-Change-Number: 42141
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 26 May 2021 14:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment