Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39097 )
Change subject: soc/mediatek/mt8183: Add get dram type API at ATF
......................................................................
Patch Set 4: Code-Review-1
Please don't subvert parameter types for something they weren't meant to be. You can create a new vendor-specific parameter type in TF if you need to.
(Do you really need to pass a parameter for this? Is there no way for TF to detect this information from the EMC registers that were already configured for the right type by coreboot?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20afc00c4c671abcbb6f36eb8e3e364529e9389c
Gerrit-Change-Number: 39097
Gerrit-PatchSet: 4
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Feb 2020 02:54:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment