Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36207 )
Change subject: ec/google/chromeec: Add EC driver support for software sync
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36207/13/src/ec/google/chromeec/ec....
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/36207/13/src/ec/google/chromeec/ec....
PS13, Line 682: EC_VER_FLASH_WRITE
Just use flashrom -p ec? That's how we update our EC manually (both RO and RW).
sure, but not sure I want to risk updating the active EC firmware on a live system - at least not someone else's. Much easier and safer just to check/reboot into RO, then update and jump into RW as part of AP boot :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d3c5184dbe96f04b92878f2c19c7875503a910a
Gerrit-Change-Number: 36207
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 03:31:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment