Attention is currently required from: Bora Guvendik, Cliff Huang, Hannah Williams, Jérémy Compostella, Pranava Y N, Subrata Banik.
Wonkyu Kim has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84901?usp=email )
Change subject: soc/intel/common/gpio: add function to lock GPIO configuration
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/84901/comment/dd45b336_01013355?usp... :
PS3, Line 485: /* Clear lock for the exception PADs */
Hi Subrata, This is a TODO to a TODO. […]
I think it's implementation way difference.
We can lock each pin mux table by using existing _LOCK macro but it may be work if we want to lock some of pin's configuration.
Basic assumption for this change(having exception table for lock) is for locking most of pin configuration for system safety. And it'll require less change compared to changing entire pin configuration in gpio.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84901?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabe4e4b1d282a5f6cae8f330100c9139e0c2691d
Gerrit-Change-Number: 84901
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Thu, 31 Oct 2024 23:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hannah Williams
hannah.williams@intel.com
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com