Attention is currently required from: Angel Pons, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78827?usp=email )
Change subject: sb/intel/bd82x6x/early_usb: Print error for invalid USB setting ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78827/comment/9df54597_45e65aa3 : PS3, Line 11: have a such
have such a
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/78827/comment/8b706742_a32f1c98 : PS6, Line 9: According to BWG the USB current setting 0 should not be used for desktop
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/c/coreboot/+/78827/comment/1734f50d_038af0a2 : PS3, Line 29: not a valid
an invalid
Done
File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/c/coreboot/+/78827/comment/dad81f1d_fad47366 : PS6, Line 31: printk(BIOS_ERR, "%s: USB%02d: current setting of 0 is not a valid setting for desktop!\n",
Most people will see these errors and not know what to do with them. […]
That's obvious from the error message. Everything besides 0 is a better choice. Added a comment what to do.