Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: mb/ocp/deltalake: Set coreboot log level via VPD variable
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
I guess this could be moved to some generic location?
Maybe drivers/vpd or src/console and add a new config option for this?
src/console makes more sense to me. The input may be come from VPD, or something else (depending on platform). So:
* Use the CONFIG_DEFAULT_CONSOLE_LOGLEVEL_* as default.
* If CONFIG_CONSOLE_LOGLEVEL_OVERRIDE is defined, call a platform specific function to get the desired log level, and use it.
* Deltalake platform code implements the platform specific function which queries COREBOOT_LOG_LEVEL vpd variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 19:49:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment