[coreboot-gerrit] Change in coreboot[master]: security/intel/stm: Add STM support

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )

Change subject: security/intel/stm: Add STM support
......................................................................

Patch Set 57:

(3 comments)

https://review.coreboot.org/c/coreboot/+/33234/57/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33234/57/src/cpu/x86/mp_init.c@750 
PS57, Line 750: 		if (is_smm_enabled()) {
What's this about? AFAICS, we are in SMM.

https://review.coreboot.org/c/coreboot/+/33234/57/src/cpu/x86/smm/smm_module... 
File src/cpu/x86/smm/smm_module_loader.c:

https://review.coreboot.org/c/coreboot/+/33234/57/src/cpu/x86/smm/smm_module... 
PS57, Line 365: 		base += size - CONFIG_MSEG_SIZE;     // take out the mseg
What is MSEG, why is it not in the picture above?

https://review.coreboot.org/c/coreboot/+/33234/57/src/cpu/x86/smm/smm_module... 
PS57, Line 398: 	// account for the bios resource list
This comment and the empty lines kind of break the relation of the comment
in line 394 and line 402.