Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for common enclosures ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31206/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/31206/3/src/Kconfig@335 PS3, Line 335: default n
Shouldn't this be […]
I was worried that it would make some boards that are laptop end up reporting desktop (in their resulting .config) which were before in some "unknown" state by not reporting anything.
But smbios was defaulting to desktop anyway, and I suppose it is good incentive to select the system type in the board kconfig.
https://review.coreboot.org/#/c/31206/3/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/31206/3/src/arch/x86/acpi.c@1069 PS3, Line 1069: if (IS_ENABLED(CONFIG_SYSTEM_TYPE_DESKTOP))
Afaik this approach will cause the builds for configs that don't specify a type to switch from deskt […]
I was hoping to avoid a lot of checks but you are right...