25 Apr
2019
25 Apr
'19
1:59 a.m.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30754 )
Change subject: mb/google/poppy/variant/atlas: enable USB acpi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... PS1, Line 284: reset_gpio usb-acpi doesn't seem to have the concept of an enable_gpio. is there a way to define this pin as an enable pin similar to what we do for the touchscreen a few lines down?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I411ef707782655361bd1b8ac2b914b8ae64defeb
Gerrit-Change-Number: 30754
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai gaggery.tsai@intel.com
Gerrit-Reviewer: Caveh Jalali caveh@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Gaggery Tsai gaggery.tsai@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 25 Apr 2019 08:59:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment