Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 5: define Don't you need to include this file from somewhere else? Like in the main PCH asl file?
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 88: Subtract Please use the new asl syntax where possible
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... PS11, Line 340: ALIGN_UP Use DIV_ROUND_UP instead?