Hello Kyösti Mälkki, Patrick Rudolph, Angel Pons, Julius Werner, Arthur Heymans, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37358
to look at the new patch set (#4).
Change subject: src/: Remove g_ prefixes and _g suffixes from variables ......................................................................
src/: Remove g_ prefixes and _g suffixes from variables
These were often used to distinguish CAR_GLOBAL variables that weren't directly usable. Since we're getting rid of this special case, also get rid of the marker.
This change was created using coccinelle and the following script: @match@ type T; identifier old =~ "^(g_.*|.*_g)$"; @@ old
@script:python global_marker@ old << match.old; new; @@ new = old if old[0:2] == "g_": new = new[2:]
if new[-2:] == "_g": new = new[:-2]
coccinelle.new = new
@@ identifier match.old, global_marker.new; @@ - old + new
@@ type T; identifier match.old, global_marker.new; @@ - T old; + T new;
@@ type T; identifier match.old, global_marker.new; @@ - T old + T new = ...;
It was not applied to src/soc/intel/cannonlake/chip.c and src/cpu/intel/turbo/turbo.c which actually use both local and global variables, following the scheme.
Change-Id: I4936ff9780a0d3ed9b8b539772bc48887f8d5eed Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/cpu/intel/common/fsb.c M src/cpu/x86/lapic/apic_timer.c M src/cpu/x86/tsc/delay_tsc.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/i2c/tpm/cr50.c M src/drivers/i2c/tpm/tis.c M src/drivers/i2c/tpm/tpm.c M src/drivers/pc80/pc/i8254.c M src/drivers/spi/flashconsole.c M src/drivers/spi/tpm/tpm.c M src/drivers/vpd/vpd.c M src/soc/intel/common/block/cse/cse.c M src/soc/nvidia/tegra/i2c.c M src/southbridge/intel/common/spi.c M src/vendorcode/google/chromeos/ramoops.c 16 files changed, 314 insertions(+), 311 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37358/4