Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO
......................................................................
Patch Set 5:
(4 comments)
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@7
PS4, Line 7: isoc
Oops, looks like a spurious `i` got added. […]
ya. Side effect of getting too used to vim.will remove.
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9
PS4, Line 9: lake
Capitalize: `Lake`
Ack
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9
PS4, Line 9: gpio
Uppercase: GPIO (all of them)
Ack
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@13
PS4, Line 13: acpi
Uppercase: ACPI
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44
Gerrit-Change-Number: 39344
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 19:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment