Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )
Change subject: mb/google/hatch: Configure miscellaneous features ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... PS8, Line 53: # Enable heci communication : register "HeciEnabled" = "1"
We do not want to keep the HECI interface up when jumping to OS. […]
this is just to ensure that FSP don't disable CSME interface before sending EOP which is not recommended.
Please check lspci on your any WHL based device, i hope you will see CSME bus 0, device 0x16, function 0 is default enable with and without this changes. There is some open which we need to address in order to function disable CSME before booting to OS after sending EOP.
Kindly look at CNL implementation of function disabling of CSME. If you have CNL device, you won't see CSME in lspci even this UPD is enable. The concern is that same implementation as CNL won't be applied here for CFL and WHL platform.