Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )
Change subject: commonlib/bsd: Add new CBFS core implementation ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38421/5/src/commonlib/bsd/include/c... File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
https://review.coreboot.org/c/coreboot/+/38421/5/src/commonlib/bsd/include/c... PS5, Line 7: #include <vb2_sha.h>
is this going to be part of commonlib? […]
Yes, all software that wants to build commonlib code may also need to build vboot. That's just unavoidable if I want to have all this hashing stuff integrated in the commonlib CBFS stack. vboot is already BSD licensed so this would not be a restriction in that area.
I'm not sure how it would make sense to ship this header individually anywhere. This is only interesting to CBFS readers, and my goal with all this is to unify all CBFS readers into using the same cbfs_walk() commonlib code anyway.