Attention is currently required from: Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78292?usp=email )
Change subject: lib/smbios: Improve Type9
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78292/comment/febf1589_6a1f0c68 :
PS1, Line 13: no difference though.
Why the word 'though'? Were you expecting tha PME would be set to indicate wake-on-wlan -capability?
It turns out dmidecode doesn't print any cap when BIT0 in characteristics_1 is set. Need to update that as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78292?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If96e0381b10c25cf73b3797a0f02a40dc933993e
Gerrit-Change-Number: 78292
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 17 Oct 2023 12:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment