12 Mar
2020
12 Mar
'20
7:43 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 13:
(1 comment)
There are still some open comments in patch set 2 and 5. Please review and handle as appropriate.
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 111: SdCardPowerEnableActiveHigh
Hello Furquan, […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/39237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c8ceb85ada23718ff7b6fd7013317c818dd532
Gerrit-Change-Number: 39237
Gerrit-PatchSet: 13
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Mar 2020 07:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya varshit.b.pandya@intel.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment