Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38423 )
Change subject: cbfs: Add metadata cache ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38423/4/src/commonlib/bsd/cbfs_mcac... File src/commonlib/bsd/cbfs_mcache.c:
https://review.coreboot.org/c/coreboot/+/38423/4/src/commonlib/bsd/cbfs_mcac... PS4, Line 72: ERROR("mcache overflow, should increase CBFS_MCACHE size!\n");
The goal of the design is that things are still usable when the cache is too small. […]
I changed my mind a bit about how this works -- I still think we need to support cases with RW updates where the mcache might overflow, but I am passing CB_CBFS_CACHE_FULL out to the caller now so that the decision what to do about it can be made at that level.
https://review.coreboot.org/c/coreboot/+/38423/4/src/commonlib/bsd/cbfs_mcac... PS4, Line 123:
See above... this is necessary to support the cache full case. […]
Changed now as mentioned above. Pushed the responsibility for this to the caller so it can decide whether to die() or fall back to cbfs_lookup() or whatever. Makes the function signature a bit less bulky, too.