Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33330 )
Change subject: device/pci_rom.c: Fix indent for 'if' statement and remove unneeded 'else' ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33330/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/33330/1/src/device/pci_rom.c@58 PS1, Line 58: } else if (!CONFIG(ON_DEVICE_ROM_LOAD)) { This code flow isn't the same as before though. Before we had:
1) if (rom_header) 2) else if (!CONFIG()) 3) else then 4) more code
we would execute the code in code path 2 and return or paths 1 or 3, then always 4. Now we're executing code path 2 and returning, or executing path 1, then always 3 & 4.
1) if 2) else then 3) code and 4) code
Is that what we want?