Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35656 )
Change subject: [WIP] soc/intel: Replace config_of_path() with config_of_soc()
......................................................................
Patch Set 1:
(1 comment)
Richard, Marshall: Accessing dev->chip_info should be cleaned up under soc/amd.
https://review.coreboot.org/c/coreboot/+/35656/1/src/include/device/device.h
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/35656/1/src/include/device/device.h...
PS1, Line 317: static inline DEVTREE_CONST void *config_of_soc(void)
: {
: return config_of(pcidev_on_root(0, 0));
: }
Overall the change looks good to me. […]
Right... I think we can find different way to find top-level .chip_info, so implementation would not depend on PCI 0:0.0 and becomes usable for soc/amd as well.
Platforms with separate cpu/,nb/,sb/ could not use config_of_soc() anyways, but config_of(dev) instead. The configuration structures are split like the directories.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf13645fdd3ef7fd3d5c8217bb24d7ede045c790
Gerrit-Change-Number: 35656
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 28 Sep 2019 22:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment