[coreboot-gerrit] Change in coreboot[master]: device/xhci: Add an xhci driver to enumerate capabilities

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )

Change subject: device/xhci: Add an xhci driver to enumerate capabilities
......................................................................

Patch Set 2: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c 
File src/device/xhci.c:

https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c@31 
PS2, Line 31: find_resource
Please use probe_resource.
Find_resource will die instead of returning NULL

https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c@38 
PS2, Line 38: res->limit > 0xFFFFFFFF
> Should res->base be checked as well?

It should only check res->base. The resource allocator might still allocate below 4GiB even on a 64bit bar.

https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c@43 
PS2, Line 43: base
Use res2mmio

https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c@67 
PS2, Line 67: ext_cap_ptr
Check that you are still within the BAR.