[coreboot-gerrit] Change in ...coreboot[master]: lib: Rewrite qemu-armv7 ramdetect

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33934 )

Change subject: lib: Rewrite qemu-armv7 ramdetect
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/33934/1/src/lib/ramdetect.c 
File src/lib/ramdetect.c:

https://review.coreboot.org/#/c/33934/1/src/lib/ramdetect.c@25 
PS1, Line 25: int
> Use CB_SUCCESS and friend?

no as result is used in arithmethics

https://review.coreboot.org/#/c/33934/1/src/lib/ramdetect.c@31 
PS1, Line 31: clobering
> clober

Done

https://review.coreboot.org/#/c/33934/1/src/lib/ramdetect.c@66 
PS1, Line 66: 	if (msb > (sizeof(size_t) * 8 - 20))
> Can you add a comment, why multiply by 8 and subtract 20?

Done