Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39050 )
Change subject: cpu/intel/xeonsp: Cache BIOS SPI region
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39050/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39050/2//COMMIT_MSG@10
PS2, Line 10: This seems to be an undocumented requirement
: for FSP-M to function correctly.
AFAIK, it is a documented requirement of the MRC (Memory Reference Code).
I think FSP-M also does QPI/UPI init. Performing any flash accesses while initializing QPI does not seem to be a good idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926722ecd7237bea236a4906b899a51e4963f740
Gerrit-Change-Number: 39050
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 24 Feb 2020 15:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment