Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45012 )
Change subject: soc/intel/common: Add SMRR Lock Supported bit definition for MTRR_CAP ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/msr.h:
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/... PS1, Line 106: reg ugh, this needs parens.
separate patch 😊
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/... PS1, Line 109: (1<<11) : #define PRMRR_SUPPORTED (1<<12) : #define SMRR_LOCK_SUPPORTED (1<<14) could you use the prevailing style and add spaces around the operator?