Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl...
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl...
PS3, Line 162: # register "sdcard_cd_gpio" = "GPP_G5"
good practice would be add TODO section here to tell the problem why you have commented this code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017
Gerrit-Change-Number: 38259
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 02:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment