Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: HACK sc7280: QSIP SPI NOR addressing mode HACK
......................................................................
Patch Set 47:
(1 comment)
File src/drivers/spi/spi_flash.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121776):
https://review.coreboot.org/c/coreboot/+/50586/comment/92fd74b5_a4a1c3b4
PS47, Line 508: while (1);
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
Gerrit-Change-Number: 50586
Gerrit-PatchSet: 47
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment