Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@9
PS2, Line 9: frequncy
frequency
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10
PS2, Line 10: ov2740 user-facing camera.
Where did you get the new values from?
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@15
PS2, Line 15: and check user-facing camera functionalities
Please add a dot/period at the end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e
Gerrit-Change-Number: 41157
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 May 2020 10:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment