Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85718?usp=email )
Change subject: util/crossgcc: Update DESTDIR variable use ......................................................................
util/crossgcc: Update DESTDIR variable use
Update DESTDIR variable use to prevent unintended separation and globbing.
BUG=None TEST=./util/crossgcc/buildgcc
Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2 Signed-off-by: Jon Murphy jpmurphy@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85718 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Raul Rangel: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index a751003..2d112eb 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -867,10 +867,10 @@ mkdir -p gcc/$TARGETARCH && \ # shellcheck disable=SC2086 $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libgcc && \ - $MAKE install-target-libgcc DESTDIR=$DESTDIR && \ + $MAKE install-target-libgcc DESTDIR="$DESTDIR" && \ # shellcheck disable=SC2086 $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libstdc++-v3 && \ - $MAKE install-target-libstdc++-v3 DESTDIR=$DESTDIR || touch .failed + $MAKE install-target-libstdc++-v3 DESTDIR="$DESTDIR" || touch .failed }
build_GCC() {