Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Johnny Lin, Ed Sharma, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram.
Hello Arthur Heymans, build bot (Jenkins), Furquan Shaikh, Subrata Banik, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66819
to look at the new patch set (#2).
Change subject: Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers.
......................................................................
Recently published Intel CedarIslandFSP binary contains PE images in
FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers.
The change required to add support for pe_relocate in fsp-relocate.c
I had to move a few functions to top of file as they need to be used
by pe_relocate but were placed below the te_relocate function. I chose
to place pe_relocate function next to te_relocate.
The code supports PE32 format, not PE64, at this time.
TEST=
This code is tested with FSP version 33A for DeltaLake boot.
Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e
Signed-off-by: Eddie Sharma aeddiesharma@fb.com
---
M src/commonlib/fsp_relocate.c
1 file changed, 214 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/66819/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e
Gerrit-Change-Number: 66819
Gerrit-PatchSet: 2
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-MessageType: newpatchset