[coreboot-gerrit] Change in coreboot[master]: arch/x86/smbios: Populate SMBIOS type 7 with cache information

[Morgan Jang (Code Review)]

Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46068 )

Change subject: arch/x86/smbios: Populate SMBIOS type 7 with cache information
......................................................................

Patch Set 13:

(5 comments)

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c@503 
PS11, Line 503: /* Provide sane defaults even for CPU without CPUID */
              : 	res.eax = res.edx = 0;
              : 	res.ebx = 0x10000;
> This isn't necessary anymore

Done

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c@516 
PS11, Line 516: `
> nit: this is a backtick, but should be a single quote instead: '

Done

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c@519 
PS11, Line 519: 	} else {
> It would be good to handle this

Done

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c@766 
PS11, Line 766: t->max_cache_size *= number_of_caches;
              : 	t->installed_size *= number_of_caches;
              : 	t->max_cache_size2 *= number_of_caches;
              : 	t->installed_size2 *= number_of_caches;
> This will cause problems with the `SMBIOS_CACHE_SIZE_UNIT_64KB` flag set above. […]

Done

https://review.coreboot.org/c/coreboot/+/46068/11/src/arch/x86/smbios.c@870 
PS11, Line 870: cache_size
> How about multiplying by `get_number_of_caches()` here instead?

Done