Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40817 )
Change subject: mb/google/kahlee: Start PCIe reset sooner on careena devices
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40817/1/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/careena/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40817/1/src/mainboard/google/kahlee...
PS1, Line 17: romstage-y += variant.c
Sorry Kevin, didn't mean to push this as part of this patch.
Hi Martin, not at all, this should be kept in baseboard, not in variant, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40817
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2d2c72445daeea8567b8ee989533785c35667e8
Gerrit-Change-Number: 40817
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Apr 2020 02:23:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment