Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32874 )
Change subject: fit: Check all compat strings for highest match
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32874/5/src/lib/fit.c
File src/lib/fit.c:
https://review.coreboot.org/#/c/32874/5/src/lib/fit.c@461
PS5, Line 461: if (pos >= 0) {
should we compare pos with config->compat_pos? how do we make sure the pos after look is the highest?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3d84bbce6de3cd49c746a667ae1ccfdc843105
Gerrit-Change-Number: 32874
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Jun 2019 06:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment