Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )
Change subject: amd/picasso/verstage: replace rsa accel with modexp
......................................................................
Patch Set 5:
Patch Set 5:
st
Not sure why I got an "st" on this. Apologies. I think Angel is commenting that we are doing some byte swizzling and that the preferred implementation is to treat the buffer in both a: the right size, and b: not swizzle if possible. So we should explore this in a follow up bug with AMD on refining the svc call.
Angel to agree/disagree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I085f043bf2014615d2c9db6df0b7947ee84b9546
Gerrit-Change-Number: 45987
Gerrit-PatchSet: 5
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Oct 2020 02:21:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment