Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61503 )
Change subject: mb/google/brya: Remove `mb_gpio_lock_config()` override function
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Are you going to follow this up with a change to src/soc/intel/common/block/smm/smihandler. […]
Thanks for the pointer, yes, we should.
Also, I believe Eric will pick the Soc lock config clean up sooner so we can remove soc_lock_gpios() as well.
Thoughts ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc7354f2ae3817459b5494d572c603eba48ec66a
Gerrit-Change-Number: 61503
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Feb 2022 20:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment