Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32375 )
Change subject: postcar_loader: Use size_t ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32375/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32375/4//COMMIT_MSG@8 PS4, Line 8: : To make it easier to pop arguments from stack use size_t instead of int. : This is a noop on x86_32.
I'm not very well aware of how amd64 works but why is using 32bit math/ stack pop not an option?
POP r32 instruction is marked N.E. (not encodable) in 64-bit mode.
https://review.coreboot.org/#/c/32375/4/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/32375/4/src/arch/x86/postcar_loader.c@32 PS4, Line 32: pcf->stack -= sizeof(val); \ It's confusing with x86_64 if you allow the stack pointer to break alignment to 8 bytes.
https://review.coreboot.org/#/c/32375/4/src/arch/x86/postcar_loader.c@99 PS4, Line 99: stack_push(pcf, addr | type); Proper aligment of values on the stack might be lost here with x86_64.