Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@7 PS5, Line 7: m
mb/lenovo/x230/var/x230s: Remove unnecessary code and comments
Done
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@13 PS5, Line 13: will remove
present tense: removes
Done
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/... PS16, Line 22: !BOARD_LENOVO_X230S
That there are mixed `!BOARD_LENOVO_X230S` and `BOARD_LENOVO_X230 || BOARD_LENOVO_X230T` is odd.
Done
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... PS11, Line 65: register "superspeed_capable_ports" = "0xf"
please move superspeed_capable_ports into a seperate commit.
Done, as CB:41510.