Attention is currently required from: Henry Sun, Sumeet R Pawnikar, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 )
Change subject: mb/google/dedede/var/galtic: Add charger throttling function
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54673/comment/411a8df3_b4751000
PS2, Line 11: 187231627
Nit: "b:187231627"
Done
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54673/comment/fe8190d8_8652dd4a
PS3, Line 106: 2000 },
: [1] = { 24, 2000 },
: [2] = { 16, 2000 },
: [3] = { 8, 2000
Please, explain the reason why your current throttled value is constant (2000) for all control entri […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54673
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7
Gerrit-Change-Number: 54673
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 27 May 2021 08:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment