Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40424 )
Change subject: ec/google/chromeec: Add support for USB Type-C alternate mode control ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi... PS1, Line 74: Package
Thanks for confirming, that is what I expected.
Ack
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi... PS2, Line 62: GOOG0013 The device ID should be GOOG0014
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi... PS2, Line 71: Name (_ADR, 0) : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package() { : Package () { "usb-role-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "mode-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "orientation-switch", : _SB.PCI0.PMC.MUX.CON0 }, : Package () { "power-role", "dual" }, : Package () { "data-role", "dual" }, : } : }) : Please check with twawrzynczak@.
These properties will be getting auto-generated, so instead ensure that the correct board-file/devicetree settings are enabled for this board.