[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel: Avoid NULL pointer dereference

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33152 )

Change subject: src/soc/intel: Avoid NULL pointer dereference
......................................................................

src/soc/intel: Avoid NULL pointer dereference

Coverity detects pointer mem_info as NULL_RETURNS. Add sanity check
for mem_info to prevent NULL pointer dereference.

BUG=CID 1401394
TEST=Built and boot up to kernel.

Change-Id: I9d78ab38b8b2dd3734e0143acfd88d9093f16ce6
Signed-off-by: John Zhao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33152
Reviewed-by: Martin Roth 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/broadwell/romstage/raminit.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

Objections:
  Paul Menzel: I would prefer that you didn't submit this

diff --git a/src/soc/intel/broadwell/romstage/raminit.c b/src/soc/intel/broadwell/romstage/raminit.c
index fc8b7c6..c13761d 100644
--- a/src/soc/intel/broadwell/romstage/raminit.c
+++ b/src/soc/intel/broadwell/romstage/raminit.c
@@ -122,6 +122,12 @@

printk(BIOS_DEBUG, "create cbmem for dimm information\n");
    mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(struct memory_info));
+
+	if (!mem_info) {
+		printk(BIOS_ERR, "Error! Failed to add mem_info to cbmem\n");
+		return;
+	}
+
    memset(mem_info, 0, sizeof(*mem_info));
    /* Translate pei_memory_info struct data into memory_info struct */
    mem_info->dimm_cnt = pei_data->meminfo.dimm_cnt;