[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

Patch Set 5: Code-Review+2

(2 comments)

Even I am tired of bikeshedding on this change

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
PS3, Line 83: 	assert(size_mb != 0);
> If we do that and size_mb is 0, then it will get rounded up to 1 after the fb_pow stuff and then pri […]

Ah, true.

https://review.coreboot.org/c/coreboot/+/34355/5/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/5/src/northbridge/via/vx900/m... 
PS5, Line 20: #include <assert.h>
Can drop this now